lib/proto: add support for instantiating proto map fields #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Fixed author email address for CLA. |
tazjin
force-pushed
the
proto-maps
branch
2 times, most recently
from
f05b3e6
to
63e081c
Compare
adonovan
approved these changes
Jul 26, 2023
adonovan
reviewed
Jul 26, 2023
With this change, it becomes possible to instantiate `map<k,v>` type fields in Protobuf messages from Starlark. Maps can be constructed from any Starlark type that implements starlark.IterableMapping. Protobuf messages can have most types as keys/values, so the type conformity is checked individually for each key/value pair (as the Starlark side of things is dynamically typed). This has been tested against fairly complex proto messages containing maps. Map operations apart from construction are not supported in this CL.
|
Fixed those, thanks. |
adonovan
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it becomes possible to instantiate
map<k,v>type fields in Protobuf messages from Starlark.Maps can be constructed from any Starlark type that implements starlark.IterableMapping.
Protobuf messages can have most types as keys/values, so the type conformity is checked individually for each key/value pair (as the Starlark side of things is dynamically typed).
This has been tested against fairly complex proto messages containing maps.
Map operations apart from construction are not supported in this CL.